[Bug 459153] Review Request: ann - Library for searching Approximate Nearest Neighbors

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459153


Jason Tibbitts <tibbs at math.uh.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu




--- Comment #1 from Jason Tibbitts <tibbs at math.uh.edu>  2008-08-16 11:08:26 EDT ---
I believe the license is LGPLv2+; where do you see that it is restricted to v2
only?

There is really no need to duplicate those three documentation files between
the main and -libs packages.  You can duplicate the actual license text if you
really feel the need to (even though the lawyers have indicated that it is not
necessary) but there's really no point in duplicating things like ReadMe.txt.

* source files match upstream:
   b21d7992bb69d56be2cec0e57c3bfb2ce3497570827edccf3cf403e2c2143898  
   ann_1.1.1.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
X license field does not match the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper (none).
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* debuginfo package looks complete.
* rpmlint is silent.
* final provides and requires are sane:
  ann-1.1.1-1.fc10.x86_64.rpm
   ann = 1.1.1-1.fc10
   ann(x86-64) = 1.1.1-1.fc10
  =
   libANN.so.1()(64bit)
   libgcc_s.so.1()(64bit)
   libgcc_s.so.1(GCC_3.0)(64bit)
   libstdc++.so.6()(64bit)
   libstdc++.so.6(CXXABI_1.3)(64bit)
   libstdc++.so.6(GLIBCXX_3.4)(64bit)

  ann-devel-1.1.1-1.fc10.x86_64.rpm
   ann-devel = 1.1.1-1.fc10
   ann-devel(x86-64) = 1.1.1-1.fc10
  =
   ann-libs = 1.1.1-1.fc10
   libANN.so.1()(64bit)

  ann-libs-1.1.1-1.fc10.x86_64.rpm
   libANN.so.1()(64bit)
   ann-libs = 1.1.1-1.fc10
   ann-libs(x86-64) = 1.1.1-1.fc10
  =
   /sbin/ldconfig
   libANN.so.1()(64bit)
   libgcc_s.so.1()(64bit)
   libgcc_s.so.1(GCC_3.0)(64bit)
   libstdc++.so.6()(64bit)
   libstdc++.so.6(CXXABI_1.3)(64bit)
   libstdc++.so.6(GLIBCXX_3.4)(64bit)
   libstdc++.so.6(GLIBCXX_3.4.9)(64bit)

* %check is not present; no test suite upstream.
  I have no idea how to test this package.  I can at least run the ann2fig 
  binary but I don't know what to pass to it.  Maybe there's something in the 
  sample directory, but it doesn't seem to be installed anywhere.

* shared libraries installed:
   ldconfig called properly.
   unversioned .so link is in the -devel package.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
X documentation is duplicated between packages.
* file permissions are appropriate.
* scriptlets are OK (ldconfig).
* code, not content.
* headers are in the -devel package.
* no pkgconfig files.
* no static libraries.
* no libtool .la files.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.