[Bug 458826] Review Request: s390utils - Linux/390 specific utilities

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=458826





--- Comment #3 from Jason Tibbitts <tibbs at math.uh.edu>  2008-08-16 12:29:34 EDT ---
I haven't a hope of testing this, but of course I can review for form and
rpmlint still provides some useful information.  I guess the first thing I
notice, though, is that the packages in your koji instance have an .fc8 dist
tag even though they were build on dist-f9.  Any idea what's happened there?

  s390utils.src:134: W: configure-without-libdir-spec
This is OK; it's not an autoconf-generated configure script.
  s390utils.src: E: description-line-too-long   - qetharp to query and purge 
   address data in the OSA and HiperSockets hardware
This goes to exactly 80 characters.  I'm not sure if rpmlint is off by one or
if the limit is really 79 or less, but it might be better to wrap it.

  s390utils.s390x: E: executable-sourced-script /etc/profile.d/s390.csh 0755
  s390utils.s390x: E: executable-sourced-script /etc/profile.d/s390.sh 0755
Generally there's no reason for these to be executable, although this wouldn't
be the only package to make this error.

  s390utils.s390x: E: init-script-without-chkconfig-postin  
   /etc/rc.d/init.d/dumpconf
  s390utils.s390x: E: init-script-without-chkconfig-postin 
   /etc/rc.d/init.d/mon_procd
  s390utils.s390x: E: init-script-without-chkconfig-postin 
   /etc/rc.d/init.d/mon_statd
  s390utils.s390x: E: init-script-without-chkconfig-preun 
   /etc/rc.d/init.d/dumpconf
  s390utils.s390x: E: init-script-without-chkconfig-preun 
   /etc/rc.d/init.d/mon_procd
  s390utils.s390x: E: init-script-without-chkconfig-preun 
   /etc/rc.d/init.d/mon_statd
Seems like the scriptlets to add these services are missing completely.

  s390utils.s390x: E: non-readable /etc/udev/rules.d/56-dasd.rules 0700
  s390utils.s390x: E: non-readable /etc/udev/rules.d/56-zfcp.rules 0700
  s390utils.s390x: E: script-without-shebang /etc/udev/rules.d/56-dasd.rules
  s390utils.s390x: E: script-without-shebang /etc/udev/rules.d/56-zfcp.rules
Any reason for the udev rules to not be 644 like the rest of them?

There are several "non-readable" and "non-standard-executable-perm" complaints
form the main package.  I believe these are OK.

  s390utils.s390x: E: subsys-not-used /etc/rc.d/init.d/dumpconf
  s390utils.s390x: E: subsys-not-used /etc/rc.d/init.d/mon_procd
  s390utils.s390x: E: subsys-not-used /etc/rc.d/init.d/mon_statd
Not sure what's up here.  None of these drop locks in /var/lib/subsys, which is
generally expected of daemons.  I'm not sure what to make of these, and the
wiki is offline so I can't get to the initscript guidelines.

  s390utils.s390x: W: file-not-utf8 /usr/share/doc/s390utils-1.7.0/README
Should be converted.

  s390utils.s390x: W: no-soname /usr/lib64/src_vipa.so
I'm not sure what this is about; it could even be an artifact of running
rpmlint on an i386 machine.  Also, I think some would complain about this being
in _libdir when nothing will ever link against it.

  s390utils.s390x: W: service-default-enabled /etc/rc.d/init.d/dumpconf
  s390utils.s390x: W: service-default-enabled /etc/rc.d/init.d/mon_procd
  s390utils.s390x: W: service-default-enabled /etc/rc.d/init.d/mon_statd
Services shouldn't be enabled by default without a good reason.  Is there one?

We chatted about the LD_PRELOAD bit on IRC; I just don't understand why
LD_LIBRARY_PATH needs to be modified.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.