[Bug 459281] Review Request: corosync - The Corosync Cluster Engine

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459281





--- Comment #3 from Steven Dake <sdake at redhat.com>  2008-08-18 14:41:58 EDT ---
Jason,

Thanks for your review.

To ansewr your questions:
1) the user id is needed for IPC security.  That user id was previously part of
openais and has been moved into this package instead.  IPC authenticates all
users using a UID equal to ais (or root of course).

2) i will change the initrddir issue you mentioned.  This spec file was taken
from the original openais spec file from fedora 6 ages ago.

3) A lcrso file is a plugin with a specific binary format.  It will only be
loaded by the corosync binary for which the architecture is built.  Therefore
multilib is not an issue, since we wont have a 64 bit corosync and 32 bit
plugins.  The plugins are required to match the binary bit size of the corosync
binary.

4) Thanks for the tips on doc I will fix that.

5) The corosync main package doesn't use any library in the -devel package. 
The devel package shared objects are libraries for use by third party
developers writing software.  Just so we are clear, here is an example, and you
can correct me if I misunderstand the packaging guidelines.

User wants to write an application using the cpg service.  They install
corosync and corosync-devel.  corosync-devel provides the API header files and
library objects for usage by the application's cpg utilization.

At no time does anything in the main corosync package reference any shared
object in the devel package.  The -devel libraries are only for third party
developers.

6) man page in wrong location - thanks for the catch.

7) I really like to list everything out so that rpmbuild catches maintainer
(my) errors in packaging by telling me about a missing file or unpackaged
files.  If this will be an issue for review I can trim the list however.

---

I will make a new RPM with the following changes:
a) fix the initrdir
b) fix the service start
c) move the corosync-ctl man page to the proper package

If you feel more actions are required please let me know.

And thank you for your time reviewing the package.

Regards
-steve

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.