[Bug 456276] Review Request: freemarker - FreeMarker template engine

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=456276


Terje Røsten <terjeros at phys.ntnu.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |terjeros at phys.ntnu.no




--- Comment #3 from Terje Røsten <terjeros at phys.ntnu.no>  2008-08-19 15:44:41 EDT ---
o Source0 is almost correct, just change from prdownloads to downloads:

  Source0:       
http://downloads.sourceforge.net/%{name}/%{name}-{version}.tar.gz

  Ref: https://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net

o Your are using % style macros for everything, that's good, however then you
should replace install with %{__install} too.

o I would prefer %defattr in this form:

  %defattr(-, root, root, -)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.