[Bug 459387] Review Request: libtool2 - The GNU Portable Library Tool v2

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459387


Jochen Schmitt <jochen at herr-schmitt.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jochen at herr-schmitt.de




--- Comment #1 from Jochen Schmitt <jochen at herr-schmitt.de>  2008-08-19 16:01:36 EDT ---
Special Comment:

I think you should contact FESCo for sheduling this for F-11.

Good:
+ Rpmlint guite for source rpm.
+ Package has a proper open source license
+ Local build works fine.
+ Consitent use of rpm macros
+ All installed files are owned by the package and doesN't conflict with files
of other packages
+ Package contains verbatin test of the license
+ Mock build works fine

Bad:
- Messages from rpmlint libtool-2...

 rpmlint libtool-2.2.4-1.fc9.x86_64.rpm 
libtool.x86_64: W: devel-file-in-non-devel-package
/usr/share/libtool/libltdl/lt__strl.c
libtool.x86_64: W: devel-file-in-non-devel-package
/usr/share/libtool/libltdl/ltdl.h    
libtool.x86_64: W: devel-file-in-non-devel-package
/usr/share/libtool/libltdl/argz_.h   
libtool.x86_64: W: devel-file-in-non-devel-package
/usr/share/libtool/libltdl/libltdl/lt__private.h
libtool.x86_64: W: devel-file-in-non-devel-package
/usr/share/libtool/libltdl/loaders/dyld.c
libtool.x86_64: W: devel-file-in-non-devel-package
/usr/share/libtool/libltdl/lt_error.c
libtool.x86_64: W: devel-file-in-non-devel-package
/usr/share/libtool/libltdl/libltdl/lt_error.h
libtool.x86_64: W: devel-file-in-non-devel-package
/usr/share/libtool/libltdl/loaders/dld_link.c
libtool.x86_64: W: devel-file-in-non-devel-package
/usr/share/libtool/libltdl/libltdl/lt_system.h
libtool.x86_64: W: devel-file-in-non-devel-package
/usr/share/libtool/libltdl/libltdl/lt__glibc.h
libtool.x86_64: W: devel-file-in-non-devel-package
/usr/share/libtool/libltdl/libltdl/slist.h
libtool.x86_64: W: devel-file-in-non-devel-package
/usr/share/libtool/libltdl/lt__dirent.c
libtool.x86_64: W: devel-file-in-non-devel-package
/usr/share/libtool/libltdl/libltdl/lt_dlloader.h
libtool.x86_64: W: devel-file-in-non-devel-package
/usr/share/libtool/libltdl/loaders/preopen.c
libtool.x86_64: W: devel-file-in-non-devel-package
/usr/share/libtool/libltdl/loaders/shl_load.c
libtool.x86_64: E: script-without-shebang /usr/share/libtool/config/ltmain.sh
libtool.x86_64: W: devel-file-in-non-devel-package
/usr/share/libtool/libltdl/libltdl/lt__strl.h
libtool.x86_64: W: devel-file-in-non-devel-package
/usr/share/libtool/libltdl/lt__alloc.c
libtool.x86_64: W: devel-file-in-non-devel-package
/usr/share/libtool/libltdl/ltdl.c
libtool.x86_64: W: devel-file-in-non-devel-package
/usr/share/libtool/libltdl/slist.c
libtool.x86_64: W: devel-file-in-non-devel-package
/usr/share/libtool/libltdl/loaders/load_add_on.c
libtool.x86_64: W: devel-file-in-non-devel-package
/usr/share/libtool/libltdl/libltdl/lt__alloc.h
libtool.x86_64: W: devel-file-in-non-devel-package
/usr/share/libtool/libltdl/lt_dlloader.c
libtool.x86_64: W: devel-file-in-non-devel-package
/usr/share/libtool/libltdl/argz.c
libtool.x86_64: W: devel-file-in-non-devel-package
/usr/share/libtool/libltdl/libltdl/lt__dirent.h
libtool.x86_64: W: devel-file-in-non-devel-package
/usr/share/libtool/libltdl/loaders/loadlibrary.c
libtool.x86_64: W: devel-file-in-non-devel-package
/usr/share/libtool/libltdl/loaders/dlopen.c
libtool.x86_64: E: no-binary

$   rpmlint libtool-ltdl-2.2.4-1.fc9.x86_64.rpm
libtool-ltdl.x86_64: E: description-line-too-long system-installed ltdl
libraries; they are not needed by software built using the
libtool-ltdl.x86_64: W: invalid-license LGPL

rpmlint libtool-ltdl-devel-2.2.4-1.fc9.x86_64.rpm
libtool-ltdl-devel.x86_64: W: no-documentation
libtool-ltdl-devel.x86_64: W: invalid-license LGPL
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

- Why do you not _smp_mflags

- Package should not contains *.a and *.la files

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.