[Bug 459549] Review Request: python-ethtool - bindings for the ethtool kernel interface

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459549


Arnaldo Carvalho de Melo <acme at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
    Customer Facing|                            |---




--- Comment #2 from Arnaldo Carvalho de Melo <acme at redhat.com>  2008-08-20 09:46:58 EDT ---
Thanks for the comments, answers:

1. will check how python setup.py mechanism sets permissions, trying to find
the proper way instead of resorting to chmod in the %install section

2. fixed, now the Summary reads:

"Summary: Ethernet settings python bindings"

And the description:

%description
Python bindings for the ethtool kernel interface, that allows querying and
changing of ethernet card settings, such as speed, port, autonegotiation, and
PCI locations.

3. Fixed the version in changelog

4. I'm the upstream, made a tarball available at:

http://userweb.kernel.org/~acme/python-ethtool/

And list the git repo in the URL, good enough?

http://git.kernel.org/?p=linux/kernel/git/acme/python-ethtool.git

5. Fixed the version, its GPLv2

Was this with rpmlint? /me grumbles, I used it:

[acme at doppio python-ethtool]$ rpmlint rpm/SPECS/python-ethtool.spec 
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
[acme at doppio python-ethtool]$ 

I'll try increasing verbosity, etc.

New specfile and srpm uploaded to the same place as before. Please let me know
of any other problem.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.