[Bug 456280] Review Request: ini4j - Java API for handling files in Windows .ini format

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=456280





--- Comment #3 from Jason Tibbitts <tibbs at math.uh.edu>  2008-08-20 17:36:53 EDT ---
I'm having trouble understanding why this package uses alternatives at all. 
What good is switching out one jar?  If there's an application that needs an
older version of the jar, then that older version could be packaged as a compat
package and the consuming application could reference that specific version.

I have to say, the amount of macro use in this spec is... well... let's just
say it makes things pretty hard to read.  So hard, in fact, that I don't think
I can properly review this.  But if you really want to macro-ize things to that
degree, you need to be be consistent and use %{__install} as well.

You do not need to have explicit scriptlet dependencies for /bin/sh (although
it doesn't hurt).

You shouldn't own /etc/maven/fragments or /usr/share/maven2/poms; they are
owned by jpackage-utils.

Is it not possible to run the tests at build time in a %check section?  I see a
bunch of commented out dependencies which suggest runtime dependencies for the
unit tests, which confuses me since generally tests have no impact on the final
packages.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.