[Bug 454466] Review Request: php-pear-Console-ProgressBar - This class provides you with an easy-to-use interface to progress bars

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=454466


Jason Tibbitts <tibbs at math.uh.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu




--- Comment #1 from Jason Tibbitts <tibbs at math.uh.edu>  2008-08-20 19:03:25 EDT ---
The only issue I see is that this is missing
  Requires: php-pear(PEAR)

* source files match upstream:
   a8b6ed1b927d24cd9339b52f165382e76ef86a39a3e3b0bb23af1707f87a72f9  
   Console_ProgressBar-0.5.2beta.tgz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream (it's in the PHP source, though).
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint is silent.
X Missing php-pear(PEAR) dependency:
   php-pear(Console_ProgressBar) = 0.5.2
   php-pear-Console-ProgressBar = 0.5.2-0.1.beta.fc10
  =
   /bin/sh
   /usr/bin/pear

* %check is not present; no test suite upstream.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets are OK (pear module registration).
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.