[Bug 459705] Review Request: eigen2 - A lightweight C++ template library for vector and matrix math

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459705





--- Comment #1 from Jason Tibbitts <tibbs at math.uh.edu>  2008-08-21 15:00:21 EDT ---
I guess the only real question is if it's worth enabling the tests. 
Unfortunately I know so little of cmake that I can't figure out the proper
makefile target for actually running the tests.

* source files match upstream:
   167eb73ae79a55c957188e4c80659c03ef786773ddb7286abfca637bda3e8c73  
   eigen-2.0-alpha7.tar.bz2
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint is silent.
* final provides and requires are sane:
   eigen2 = 2.0-0.1.alpha7.fc10
   eigen2-devel = 2.0-0.1.alpha7.fc10
  =
   (nothing)
? %check is not present, but a test suite exists.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* headers are in the -devel package (since that's all there is).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.