[Bug 455067] Review Request: ferm - For Easy Rule Making

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=455067





--- Comment #3 from Pavel Alexeev <pahan at hubbitus.spb.su>  2008-08-22 05:13:53 EDT ---
Fist, Mamoru Tasaka very thanks for review.

(In reply to comment #2)
> As it seems that the current latest version is 1.3.5, would you update srpm
> first?
Of course! Moreover now last version 2.0.2. I upgrade to it.

> Some notes:
> - The name of spec file must be "ferm.spec"
Ok.
> - "ferm -" is redundant for Summary.
Ok.
> - "system/firewalls" is not a standard Group (please refer to
>   $ rpmlint -I non-standard-group
Thanks. I'm change it to "Applications/System".
But another question is why rpmlint was silent??

> - Please remove some meaningless release number suffix.
Off course. But it is not meaningless for me :)
> - The license tag "GPL" is not allowed on current Fedora packaging guidelines:
>   https://fedoraproject.org/wiki/Packaging/LicensingGuidelines
>   https://fedoraproject.org/wiki/Licensing
Ok, set it into GPLv2.
> - Source must be given by full URL:
>   https://fedoraproject.org/wiki/Packaging/SourceURL
Set to http://ferm.foo-projects.org/download/2.0/%{name}-%{version}.tar.gz
> - "Requires: perl" is redundant. Usually perl (module) related dependencies are
>   automatically detected and added to rebuilt binary rpms by rpmbuild.
I suppose that do not requires external perl modules. Requires: perl removed.
But I can't understand how it will be detected? It is based on standard
Makefile, nor perl buildsystem.
> - Move the lines:
> -----------------------------------------------------------------
> sed -i 's/PREFIX = /#PREFIX = /' config.mk
> sed -i 's/MANDIR = /#MANDIR = /' config.mk
> sed -i 's/DOCDIR = /#DOCDIR = /' config.mk
> -----------------------------------------------------------------
>   to %build or %prep (%prep is preferred for --short-circuit option)
Ok. Moved to %prep section.
> - Please use macros. /usr should be %{_prefix}, for example:
>   https://fedoraproject.org/wiki/Packaging/RPMMacros
Done.
> - Now %defattr(-,root,root,-) is preferred.
Instead of %defattr(-,root,root)? Why?
Done.

http://hubbitus.net.ru/rpm/Fedora9/ferm/ferm.spec
http://hubbitus.net.ru/rpm/Fedora9/ferm/ferm-2.0.2-0.fc9.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.