[Bug 456190] Review Request: dosemu - dos emulator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=456190





--- Comment #7 from Justin Zygmont <solarflow99 at gmail.com>  2008-08-22 12:20:19 EDT ---
thanks for this, I have been learning a lot already.  ok, I have fixed as many
errors as I could with the src.rpm, there are 2 more than I cannot understand
easily:


# rpmlint -i dosemu-1.4.0-1868svn.src.rpm
dosemu.src:27: E: use-of-RPM_SOURCE_DIR
You use $RPM_SOURCE_DIR or %{_sourcedir} in your spec file. If you have to use
a directory for building, use $RPM_BUILD_ROOT instead.

dosemu.src:28: W: configure-without-libdir-spec
A configure script is run without specifying the libdir. configure options
must be augmented with something like --libdir=%{_libdir} whenever the script
supports it.

dosemu.src: E: no-cleaning-of-buildroot %install
You should clean $RPM_BUILD_ROOT in the %clean section and just after the
beginning of %install section. Use "rm -Rf $RPM_BUILD_ROOT".

1 packages and 0 specfiles checked; 2 errors, 1 warnings.


I think the first Error just needs to have the freedos tar file in the BUILD
directory, Do you have any idea how I can copy the freedos tar file from
$RPM_SOURCE_DIR to $RPM_BUILD_ROOT in the %prep section?  Also, I cant seem to
get rid of the last error no matter what I do: no-cleaning-of-buildroot
%install.  I have uploaded the new src.rpm and spec file to:
http://fedorapeople.org/~jzygmont/  Any suggestions will go a long ways,
thanks.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.