[Bug 459540] Review Request: mediawiki-imagemap

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459540





--- Comment #4 from Peter Lemenkov <lemenkov at gmail.com>  2008-08-23 07:57:14 EDT ---
Notes:

* You should describe exact steps how to obtain source code and create tarball.
E.g. something like

# cvs -d:pserver:anonymous at cvs.sippy.berlios.de:/cvsroot/sippy export -D
2008-06-27  sippy
# tar -cjvf sippy-20080627.tar.bz2 sippy
Source0:        sippy-20080627.tar.bz2

* Versioning scheme is ugly. If (then) project will release officialtraball,
say ver. 1.0.0, then you will be forced to add %epoch to your spec, because
1.0.0 is earlier than rev[0-9].* . I suggest you to consider using the
following versioning scheme

Version: 0
Release: 0.1.svn39658%{?dist}

Note leading zero. E.g. Release == 0.RPMREV.svnSVNREV%{?dist}
With this naming scheme you won't have any troubles then upstream will release
official tarball.

Other things looks sane.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.