[Bug 458449] Review Request: perl-Log-TraceMessages - Perl extension for trace messages used in debugging

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=458449


David Timms <dtimms at iinet.net.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dtimms at iinet.net.au




--- Comment #1 from David Timms <dtimms at iinet.net.au>  2008-08-23 08:11:18 EDT ---
Starting review: {it's my first perl review, so the queries may not make sense,
if you can, provide explanation}

[OK] = fine.
[ x] issue needs fixing
[ ?] I'm unsure, unclear why this is happening.
[ !] suggestion

[OK] name: conforms to fedora naming guidelines.
[OK] version: is the most recent release. Upstream development seems to be
static.
[OK] release field in correct format
[OK] summary is <80 chars and punctuation free, matches head1 NAME.
[OK] group makes sense
[OK] license correct for perl CPAN module.
[OK] source0 is correct.
[OK] buildroot matches the second most preferred.
[OK] buildarch is correct for perl package
[OK] br makemaker is correct since Build.pl not present, but Makefile.pl is.
[OK] br HTML-FromText is a require from the script.
[OK] prep duplicates method used in other perl package.
[OK] build duplicated method used in other perl package.
[OK] install starts with erasing buildroot
[OK] install follows method used in other perl package.
[OK] check is included, follows form, and doesn't require exclusion due to
buildsys gui or network requirements.
[OK] clean buildroot is included in the correct format.
[OK] files - defattr is set
[OK] both doc files are included
[OK] owning of %{perl_vendorlib} parent folder is correct according to
guidelines.
[OK] source0 md5sum matches upstream download from cpan and uwinnipeg mentioned
above:
77687c9858a476628f0299cf4f29c727  Log-TraceMessages-1.4.tar.gz
77687c9858a476628f0299cf4f29c727  Log-TraceMessages-1.4.tar.gz.upst
77687c9858a476628f0299cf4f29c727 
perl-Log-TraceMessages-1.4-1.fc8.kwizart.src/Log-TraceMessages-1.4.tar.gz

[ !] guidelines suggest adding cc: to perl sig 
https://fedoraproject.org/wiki/Packaging/Perl#Set_inital-cc_to_.27perl-sig.27

[ ?] Data::Dumper is a listed require in the script. Does a perl package
automatically add this as br ?

[ ?] requires: value is added, but differs from the perl guidelines.

I think the guidelines may have been confused when translated between wiki
formats. Included value matches other fedora .specs {eg perl-Net-IP}

[ x] url gives a search error:
The distribution 'Log-TraceMessages' cannot be found, did you mean one of these

Not sure why this is. Can be found at:
http://cpan.uwinnipeg.ca/dist/Log-TraceMessages
However, the format in the spec file is as required by f guidelines/perl:

For CPAN-based packages the URL tag should use a non-versioned search.cpan.org
URL. E.g., if one were packaging the module Net::XMPP, the URL would be:

URL:            http://search.cpan.org/dist/Net-XMPP/

[ x] a buildrequire is not yet available:
 yum-builddep perl-Log-TraceMessages-1.4-1.fc8.kwizart.src.rpm 
perl-ExtUtils-MakeMaker-6.36-31.fc9.i386
Error: No Package found for perl(HTML::FromText) >= 1.004
- awaiting progress on 458446 for that package.
- reviewer has requested update and upstream communication.
- sub br package has been reviewed and approved, but does not seem to be built
/ released yet {infra problems ?}

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.