[Bug 459878] New: Review Request: genome - Package for the Genome Project

Sat Aug 23 14:14:18 UTC 2008

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: genome - Package for the Genome Project

https://bugzilla.redhat.com/show_bug.cgi?id=459878

           Summary: Review Request: genome - Package for the Genome
                    Project
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: nobody at fedoraproject.org
        ReportedBy: kanarip at kanarip.com
         QAContact: extras-qa at fedoraproject.org
                CC: notting at redhat.com, fedora-package-review at redhat.com
   Estimated Hours: 0.0
    Classification: Fedora

Spec URL: http://www.kanarip.com/custom/SPECS/genome.spec
SRPM URL: http://www.kanarip.com/custom/f10/SRPMS/genome-1.1.0-1.fc10.src.rpm
Description: Genome Framework

scratch builds:
- http://koji.fedoraproject.org/koji/taskinfo?taskID=781055 (f8)
- http://koji.fedoraproject.org/koji/taskinfo?taskID=781057 (f9)
- http://koji.fedoraproject.org/koji/taskinfo?taskID=781059 (f10)

RPMlint says:

[jmeeuwen at ghandalf tools]$ rpmlint -i
/home/jmeeuwen/rpmbuild/RPMS/noarch/genome-*-1.1.0-1*
genome-autostarter.noarch: W: non-conffile-in-etc
/etc/cron.d/genome-autostarter
A non-executable file in your package is being installed in /etc, but is not a
configuration file. All non-executable files in /etc should be configuration
files. Mark the file as %config in the spec file.

genome-firstboot.noarch: W: service-default-enabled
/etc/init.d/genome-firstboot
The service is enabled by default after "chkconfig --add"; for security
reasons, most services should not be. Use "-" as the default runlevel in the
init script's "chkconfig:" line and/or remove the "Default-Start:" LSB keyword
to fix this if appropriate for this service.

genome-firstboot.noarch: E: no-status-entry /etc/init.d/genome-firstboot
In your init script (/etc/rc.d/init.d/your_file), you don't have a 'status'
entry, which is necessary for good functionality.

genome-firstboot.noarch: W: no-reload-entry /etc/init.d/genome-firstboot
In your init script (/etc/rc.d/init.d/your_file), you don't have a 'reload'
entry, which is necessary for good functionality.

genome-release.noarch: E: zero-length /etc/yum.repos.d/genome.repo
genome-release.noarch: W: conffile-without-noreplace-flag
/etc/pki/rpm-gpg/RPM-GPG-KEY-genome
A configuration file is stored in your package without the noreplace flag. A
way to resolve this is to put the following in your SPEC file:
%config(noreplace) /etc/your_config_file_here

genome-repo.noarch: E: non-executable-script
/var/lib/puppet/modules/genomerepo/files/puppetca.cgi 0644
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

genome-repo.noarch: W: non-conffile-in-etc /etc/genome/bootstrap.pp
A non-executable file in your package is being installed in /etc, but is not a
configuration file. All non-executable files in /etc should be configuration
files. Mark the file as %config in the spec file.

genome-repo.noarch: E: non-executable-script
/var/lib/puppet/modules/genomerepo/files/puppet_node.sh 0644
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

genome-repo.noarch: W: non-conffile-in-etc /etc/cobbler/Genome.ks
A non-executable file in your package is being installed in /etc, but is not a
configuration file. All non-executable files in /etc should be configuration
files. Mark the file as %config in the spec file.

genome-repo.noarch: W: non-conffile-in-etc /etc/cobbler/Cloud.ks
A non-executable file in your package is being installed in /etc, but is not a
configuration file. All non-executable files in /etc should be configuration
files. Mark the file as %config in the spec file.

genome-repo.noarch: W: non-conffile-in-etc /etc/cobbler/Guest.ks
A non-executable file in your package is being installed in /etc, but is not a
configuration file. All non-executable files in /etc should be configuration
files. Mark the file as %config in the spec file.

genome-repo.noarch: E: init-script-without-chkconfig-postin
/etc/init.d/genome-repo-bootstrap
The package contains an init script but doesn't contain a %post with a call to
chkconfig.

genome-repo.noarch: E: init-script-without-chkconfig-preun
/etc/init.d/genome-repo-bootstrap
The package contains an init script but doesn't contain a %preun with a call
to chkconfig.

genome-repo.noarch: W: service-default-enabled
/etc/init.d/genome-repo-bootstrap
The service is enabled by default after "chkconfig --add"; for security
reasons, most services should not be. Use "-" as the default runlevel in the
init script's "chkconfig:" line and/or remove the "Default-Start:" LSB keyword
to fix this if appropriate for this service.

genome-repo.noarch: E: no-status-entry /etc/init.d/genome-repo-bootstrap
In your init script (/etc/rc.d/init.d/your_file), you don't have a 'status'
entry, which is necessary for good functionality.

genome-repo.noarch: W: no-reload-entry /etc/init.d/genome-repo-bootstrap
In your init script (/etc/rc.d/init.d/your_file), you don't have a 'reload'
entry, which is necessary for good functionality.

genome-repo.noarch: E: subsys-not-used /etc/init.d/genome-repo-bootstrap
While your daemon is running, you have to put a lock file in
/var/lock/subsys/. To see an example, look at this directory on your machine
and examine the corresponding init scripts.

genome-repo.noarch: W: incoherent-init-script-name genome-repo-bootstrap
The init script name should be the same as the package name in lower case, or
one with 'd' appended if it invokes a process by that name.

genome-respin.noarch: W: conffile-without-noreplace-flag
/etc/revisor/conf.d/cloud-ks.cfg
A configuration file is stored in your package without the noreplace flag. A
way to resolve this is to put the following in your SPEC file:
%config(noreplace) /etc/your_config_file_here

genome-respin.noarch: W: conffile-without-noreplace-flag
/etc/revisor/conf.d/combo-ks.cfg
A configuration file is stored in your package without the noreplace flag. A
way to resolve this is to put the following in your SPEC file:
%config(noreplace) /etc/your_config_file_here

genome-respin.noarch: W: conffile-without-noreplace-flag
/etc/revisor/conf.d/genome-f9-i386.conf
A configuration file is stored in your package without the noreplace flag. A
way to resolve this is to put the following in your SPEC file:
%config(noreplace) /etc/your_config_file_here

genome-respin.noarch: W: conffile-without-noreplace-flag
/etc/revisor/conf.d/genome-ks.cfg
A configuration file is stored in your package without the noreplace flag. A
way to resolve this is to put the following in your SPEC file:
%config(noreplace) /etc/your_config_file_here

genome-respin.noarch: W: conffile-without-noreplace-flag
/etc/revisor/genome.conf
A configuration file is stored in your package without the noreplace flag. A
way to resolve this is to put the following in your SPEC file:
%config(noreplace) /etc/your_config_file_here

12 packages and 0 specfiles checked; 8 errors, 16 warnings.

Each of which has now a ticket logged upstream.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.