[Bug 454395] Review Request: php-xmpphp - PHP XMPP Library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=454395





--- Comment #9 from Peter Lemenkov <lemenkov at gmail.com>  2008-08-23 10:46:59 EDT ---
REVIEW:

MUST Items:

+ rpmlint is silent.
+ The package named according to the Package Naming Guidelines .
+ The spec file name matches the base package %{name}, in the format
%{name}.spec.
+ The package meets the Packaging Guidelines .
+ The package licensed with a Fedora approved license and meets the Licensing
Guidelines.
+ The License field in the package spec file must match the actual license.
+ The text of the license(s) is included in %doc.
+ The spec file must be written in American English.
+ The spec file for the package MUST be legible. 
+ The sources used to build the package must match the upstream source:

[petro at Sulaco SPECS]$ md5sum ../SOURCES/xmpphp-0.1beta-r50.tar.gz*
ab0fd09f9508f99bbfbf08850695de96  ../SOURCES/xmpphp-0.1beta-r50.tar.gz
ab0fd09f9508f99bbfbf08850695de96  ../SOURCES/xmpphp-0.1beta-r50.tar.gz.orig
[petro at Sulaco SPECS]$

+ The package successfully compiles and builds into binary rpms on at least one
supported architecture (ppc).
+ All build dependencies are listed in BuildRequires.
+ A package owns all directories that it creates.
+ A package does not contain any duplicate files in the %files listing.
+ Permissions on files are set properly.
+ The package has a %clean section, which contains rm -rf $RPM_BUILD_ROOT.
+ The package must consistently use macros, as described in the macros section
of Packaging Guidelines .
+ The package contains code, or permissable content.
+ Everything, a package includes as %doc, does not affect the runtime of the
application. 
+ The package does not own files or directories already owned by other
packages. 
+ At the beginning of %install, the package runs rm -rf $RPM_BUILD_ROOT.
+ All filenames in rpm packages are valid UTF-8.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.