[Bug 459856] Review Request: ibus-hangul - The Korean hangul engine for IBus

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459856


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED




--- Comment #1 from Parag AN(पराग) <panemade at gmail.com>  2008-08-23 10:49:00 EDT ---
Review:
+ package builds in mock (rawhide i386).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=781109
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
6286e7de3232eb878b03ae3be448b904  ibus-hangul-0.1.1.20080823.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are correct
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Package ibus-hangul-0.1.1.20080823-1.fc10 =>
Provides:
 _hangul.so
Requires:
 /bin/sh
 libc.so.6
 libc.so.6(GLIBC_2.0)
 libc.so.6(GLIBC_2.1.3)
 libc.so.6(GLIBC_2.3.4)
 libc.so.6(GLIBC_2.4)
 libhangul.so.0
 python(abi) = 2.5
 rtld(GNU_HASH)

Suggestions:-
  Use make DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" install to preserve
timestamps for files(like .py and .svg) copied from tarball to rpm 

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.