[Bug 459880] Review Request: anyremote2html - WEB interface for anyRemote

bugzilla at redhat.com bugzilla at redhat.com
Sun Aug 24 04:21:30 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459880





--- Comment #1 from Rakesh Pandit <rakesh.pandit at gmail.com>  2008-08-24 00:21:29 EDT ---

Is this your first package? Are you sponsored?


[rpmbuild at rocky anyremote2html]$ rpmlint -i anyremote2html-0.5.2-1.src.rpm 
anyremote2html.src:19: W: setup-not-quiet
Use the -q option to the %setup macro to avoid useless build output from
unpacking the sources.

+ rm -rf anyremote2html-0.5.2
+ /usr/bin/gzip -dc /home/rpmbuild/rpm/SOURCES/anyremote2html-0.5.2.tar.gz
+ tar -xvvf -
drwxr-xr-x fedotov/fedotov   0 2008-08-20 21:52 anyremote2html-0.5.2/
drwxr-xr-x fedotov/fedotov   0 2007-09-12 08:32 anyremote2html-0.5.2/data/
drwxr-xr-x fedotov/fedotov   0 2007-09-12 07:45 anyremote2html-0.5.2/data/16/

use -q with setup.


anyremote2html.src:32: E: files-attr-not-set
A file or a directory entry in a %files section does not have attributes set
which may result in security issues in the resulting binary package depending
on the system where the package is built.  Add default attributes using
%defattr before it in the %files section, or use per line %attr's.

anyremote2html.src:33: E: files-attr-not-set
A file or a directory entry in a %files section does not have attributes set
which may result in security issues in the resulting binary package depending
on the system where the package is built.  Add default attributes using
%defattr before it in the %files section, or use per line %attr's.

anyremote2html.src: E: description-line-too-long WEB interface for anyRemote -
http://anyremote.sourceforge.net/ - remote control
Your description lines must not exceed 79 characters. If a line is exceeding
this number, cut it to fit in two lines.

anyremote2html.src: E: description-line-too-long software through bluetooth, IR
or TCP/IP connection. anyRemote2html acts as HTTP
Your description lines must not exceed 79 characters. If a line is exceeding
this number, cut it to fit in two lines.

anyremote2html.src: E: no-changelogname-tag
There is no %changelog tag in your spec file. To insert it, just insert a
'%changelog' in your spec file and rebuild it.

For every build %changelog needs to be updated.


anyremote2html.src: W: strange-permission anyremote2html-0.5.2.tar.gz 0755
A file that you listed to include in your package has strange permissions.
Usually, a file should have 0644 permissions.

[rpmbuild at rocky anyremote2html]$ rpmls anyremote2html-0.5.2-1.src.rpm 
-rwxr-xr-x  anyremote2html-0.5.2.tar.gz
-rw-r--r--  anyremote2html.spec

755 is bad

1 packages and 0 specfiles checked; 5 errors, 2 warnings.

[rpmbuild at rocky noarch]$  rpmlint -i anyremote2html-0.5.2-1.noarch.rpm 
anyremote2html.noarch: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

If there is any documentation e.g README doc you need to include it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list