[Bug 459902] Review Request: ocaml-bisect - OCaml code coverage tool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459902


Rakesh Pandit <rakesh.pandit at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED




--- Comment #5 from Rakesh Pandit <rakesh.pandit at gmail.com>  2008-08-24 05:38:25 EDT ---

APPROVED

rpmlint is clean except the warning message

I have i686 m/c
[rpmbuild at rocky i386]$ rp ocaml-bisect-1.0_alpha-1.fc9.i386.rpm 
ocaml-bisect.i386: W: executable-stack /usr/bin/bisect-report
1 packages and 0 specfiles checked; 0 errors, 1 warnings

warning is being taken care: #450551 You may like to update this bug now!!

[rpmbuild at rocky i386]$ rp ocaml-bisect-devel-1.0_alpha-1.fc9.i386.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

[rpmbuild at rocky SRPMS]$ rp ocaml-bisect-1.0_alpha-1.fc9.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

Required:
[x] Name (in accordance with ocaml guidelines)
[x] License -- okay src files have (or later) so GPLv3+ is correct
[x] Spec file is in American Eng and legible
[x] Build successfully
http://koji.fedoraproject.org/koji/taskinfo?taskID=782339
[x] BuildRequires 
[x] Duplicate files - nil
[NA] locale
[x] permissions -- okay
[x]  source link correct
[x] packaging guidlines
[x] Buildroot correct
[x] owns every directory it creates
[x] file encoding - checked
[x] package has no dependency on files in %doc
[x] gui
[x] No dependencies outside FHS guidelines
[x] md5sum

[rpmbuild at rocky ocaml]$ md5sum bisect-1.0-alpha.tar.gz 
2285c0af8d0e7503fbd0283a48cba944  bisect-1.0-alpha.tar.gz
[rpmbuild at rocky ocaml]$ md5sum
ocaml-bisect-1.0_alpha-1.fc10/bisect-1.0-alpha.tar.gz 
2285c0af8d0e7503fbd0283a48cba944 
ocaml-bisect-1.0_alpha-1.fc10/bisect-1.0-alpha.tar.gz

[x] unnecessary files excluded 
[x] native compiler test
[x] devel package contains right files
[x] ocaml guidelines

Optional suggestions:
-Nil-

Key NA = N/A, x = Check, ! = Problem, ? = Not evaluated

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.