[Bug 459540] Review Request: mediawiki-imagemap

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459540





--- Comment #6 from Peter Lemenkov <lemenkov at gmail.com>  2008-08-24 08:08:41 EDT ---
> I remade the package using the supposed last stable version for MediaWiki 1.13.

OK. BTW Axel Thimm right now rebuilding MediaWiki 1.13 for F-8 and F-9.

REVIEW:

MUST Items:

- rpmlint warns aboun incoherent version in changelog. Easy to fix - just add
notes about latest changes under actual version (MW1.13-0.1.r37906).
+ The package is named according to the Package Naming Guidelines .
+ The spec file name matches the base package %{name}, in the format
%{name}.spec.
+ The package meets the Packaging Guidelines .
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines.
+ The License field in the package spec file matches the actual license.
+ The spec file is written in American English.
+ The spec file for the package is legible.
+ The sources used to build the package matches the upstream source:

[petro at Sulaco SPECS]$ md5sum ../SOURCES/ImageMap-MW1.13-r37906.tar.gz*
39e7f7fceb125cf6a707d4c057b15f57  ../SOURCES/ImageMap-MW1.13-r37906.tar.gz
39e7f7fceb125cf6a707d4c057b15f57  ../SOURCES/ImageMap-MW1.13-r37906.tar.gz.orig
[petro at Sulaco SPECS]$

+ The package successfully compiles and builds into binary rpms on at least one
supported architecture (ppc).
+ All build dependencies are listed in BuildRequires.
+ A package owns all directories that it creates.
+ A package does not contain any duplicate files in the %files listing.
+ Permissions on files are set properly.
+ The package has a %clean section, which contains rm -rf %{buildroot}
+ The package consistently uses macros, as described in the macros section of
Packaging Guidelines .
+ The package contains code, or permissable content.
+ Everything, the package includes as %doc, does not affect the runtime of the
application.
+ Package does not own files or directories already owned by other packages. 
+ At the beginning of %install, the package runs rm -rf %{buildroot}
+ All filenames in rpm packages are valid UTF-8.

SHOULD Items:

- SHOULD: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.


So, finally

* please add entry to %changelog to make rpmlint happy
* consider shortening %description - no need to add notes, describing how to
download latest version (we should provide such support)
* find a minute to drop email to ustream about LICENSE inclusion

and this package is


APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.