[Bug 459540] Review Request: mediawiki-imagemap

bugzilla at redhat.com bugzilla at redhat.com
Sun Aug 24 17:56:20 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459540





--- Comment #8 from Peter Lemenkov <lemenkov at gmail.com>  2008-08-24 13:56:20 EDT ---
(In reply to comment #7)

> > * consider shortening %description - no need to add notes, describing how to
> > download latest version (we should provide such support)
> 
> Well, I'm confused here since you suggested to explain the way to get the
> sources (see https://bugzilla.redhat.com/show_bug.cgi?id=459540#c4).
>
> You mean to write it in comments inside the spec file or to remove it since the
> sources are created through an upstream service?

I thought that you use custom made svn snapshot. In such cases instructions how
to build such snapshot should be supplied in spec-file. See this one, as a
reference:

http://cvs.fedoraproject.org/viewvc/rpms/flashrom/devel/flashrom.spec?view=markup


> Thanks :-)

And one lastminute fix - please change versioning scheme again! I don't think
that using MW1.13 as "Version" is a good idea. As its just a svn-snapshot and
no official release was made so far, you should use 0, e.g.

Version: 0
Release: 0.1.%{revision}%{?dist}

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list