[Bug 445604] Review Request: Tennix! - A funny 2D tennis game

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=445604





--- Comment #8 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2008-08-26 12:00:32 EDT ---
Well, for 0.6.1-3:

* Summary
  - Usually the part like "Tennix! is a" is redundant for Summary

* SourceURL
  - I recommend to use %{name}, %{version} macros (especially %{version}).
    With using these you probably don't have to modify SourceURL
    when the version is upgraded.

* Macros
  - Use macros. /usr must be %{_prefix}.

! Timestamp
  - Would you consider to add
----------------------------------------------------------
sed -i -e 's|install -m|install -p -m|' makefile
----------------------------------------------------------
    to keep timestamps on installed files as much as possible?

* Icon caching
  - Please refer to
   
https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GTK.2B_icon_cache

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.