[Bug 460260] Review Request: pangomm - C++ wrapper for pango

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=460260





--- Comment #4 from Denis Leroy <denis at poolshark.org>  2008-08-27 13:48:09 EDT ---
> - package owns all directories it creates

Hmm, looks good to me over here. I think Mamoru-san addressed this in his
comment.

# rpm -qf /usr/share/gtk-doc/html/pangomm-1.4
pangomm-devel-2.13.7-1.fc10.i386
# rpm -qf /usr/include/pangomm-1.4
pangomm-devel-2.13.7-1.fc10.i386

> - packages containing pkgconfig (.pc) files need 'Requires: pkgconfig'

Fixed.

> I think also the devel package needs to have a "Requires: gtk-doc"
> as well as the pkgconfig requires as it uses gtk-doc

Fixed.

> "BuildRequires: pango-devel" is listed twice.

Oops. Fixed.

> The %description of -devel subpackage is not right.

Yes, odd, I can't remember where that's coming from. Fixed.

> Would you consider to use make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"

Sure. Fixed.

> %{_datadir}/gtk-doc/html/ is already marked as docDirs

Fixed.


> Would you explain why you want to remove files under
> %_libdir/pangomm-%apiver ?

In all gtkmm project tarballs, %{libdir}/%{name} always contains files
that are related to the code generation scripts use by the C++ wrapper
(the actual C++ interface code is generated dynamically by m4 scripts
when the tarball is created, i.e before build time). So these files
are not particularly useful even to a gtkmm-based project developer. I
removed them mainly to reduce polution of the libdir directory. I've
asked upstream before about this, the answer iirc was "in case someone
is interested"...



Spec URL: http://www.poolshark.org/src/pangomm.spec
SRPM URL: http://www.poolshark.org/src/pangomm-2.13.7-2.fc10.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.