[Bug 459966] Review Request: libgxim - GObject-based XIM protocol library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459966





--- Comment #1 from Parag AN(पराग) <panemade at gmail.com>  2008-08-28 01:50:03 EDT ---
Review:
+ package builds in mock (rawhide i386).
koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=784476
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
e0a74b61f39a5e39d6e7f645e2f67be7  libgxim-0.1.0.tar.bz2
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ BuildRequires are proper.
+ Compiler flags used correctly.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no static libraries.
+ libgxim.pc file present.
+ -devel subpackage exists.
+ no .la files.
+ translations are available.
+ Does owns the directories it creates.
+ ldconfig scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Package libgxim-0.1.0-1.fc10 ->
  Provides: libgxim.so.0
Requires(interp): /sbin/ldconfig /sbin/ldconfig
Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1)
libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4)
libcairo.so.2 libdbus-1.so.3 libdbus-glib-1.so.2 libgdk-x11-2.0.so.0
libgdk_pixbuf-2.0.so.0 libgio-2.0.so.0 libglib-2.0.so.0 libgmodule-2.0.so.0
libgobject-2.0.so.0 libgthread-2.0.so.0 libgxim.so.0 libpango-1.0.so.0
libpangocairo-1.0.so.0 libpthread.so.0 librt.so.1 rtld(GNU_HASH)
+ Package libgxim-devel-0.1.0-1.fc10 ->
Provides:
 pkgconfig(libgxim) = 0.1.0
Requires:
 libgxim.so.0

Suggestions:-
 1) make install should be used like
   make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"
 2) drop %doc from -devel as same you included in main package.
 3) group name for main package should be
 Group: System Environment/Libraries
 4) you can also think of adding tests directory to %doc of -devel in future

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.