[Bug 460289] Review Request: vldocking

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=460289





--- Comment #1 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2008-08-28 12:13:02 EDT ---
For 2.0.6e-1:

* SourceURL
  - Please write how you can download the tarball you use.
    ! Well, usually SOURCEx must be given by full URL, however
      for this package I cannot find the proper URL (php script perhaps
      redirects to somewhere we cannot see...). So please write
      how to get the source tarball.

* The place of %description
  - On the current spec file:
---------------------------------------------------------------
%package javadoc
Summary: Javadocs for %{name}
Group:          Documentation
%description  javadoc <======= Description begins here !!! ========
Requires: %{name} = %{version}-%{release}
Requires: jpackage-utils
This package contains the API documentation for %{name}.

---------------------------------------------------------------
    The current place of %description hides Requires. Please
    fix this.

? Symlinking
  - Would you explain why you want to name the created jar file
    as %{name}-%{version}.jar and to create a symlink, not just
    naming the jar file itself as %{name}.jar?
    ref:
    https://fedoraproject.org/wiki/Packaging/Java#Jar_file_naming

! Duplicate documents
  - %doc License....pdf for -javadoc subpackage is redundant (and
    usually removing these is recommended) as -javadoc subpackage always
    Requires: main package (but please fix %description issue).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.