[Bug 452211] Review Request: spu-binutils - Binutils for the SPU on IBM Cell processors

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=452211





--- Comment #4 from Aidan Delaney <a.j.delaney at brighton.ac.uk>  2008-08-30 05:26:12 EDT ---
This is my first package review.  I've read both the maintainers guide and the
reviewers guide.

Following the reviewer guide verbatim I find the following issues
• rpmlint reports the creation of non-standard /usr/spu directory
• BuildRequires should include gcc
• internationalisation is disabled
• ${RPM_BUILD_ROOT} used instead of %{buildroot}
I also proffer the opinion that
• ExclusiveArch may be a little restrictive, it /should/ work on x86_64

I think I can argue against some of my strict reading of the reviewers
guidelines.  A non-standard /usr/spu directory is created as this is what was
agreed for Fedora cross compilers.  Furthermore, internationalisation is
disabled because otherwise spu-binutils would overwrite the .mo files.

I believe that BuildRequires must include gcc and I suspect that the
${RPM_BUILD_ROOT} and ExclusiveArch issues are because of the style employed by
the packager, something I'm unqualified to critique.

I find the spec file easy to read and have been using binaries built from this
spec file on my own systems.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.