[Bug 460289] Review Request: vldocking

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=460289





--- Comment #3 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2008-08-30 12:33:38 EDT ---
For -2

(In reply to comment #2)
> (In reply to comment #1)
> > For 2.0.6e-1:
> > 
> > * SourceURL
> >   - Please write how you can download the tarball you use.
> I've tried the url too but it's clear there is some magic in the website to not
> let that.

  - Well, my comment was unclear. What I meant is that you should write as
comments
    how we can download the tarball. So
    * The URL tag can be http://www.vlsolutions.com/en/download/
    * And please write as a comment that the tarball you are using can be
downloaded
      from the redirect from
http://www.vlsolutions.com/en/download/downloader2_0.php

One cosmetic issue:
W: mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line 1)
  - You are using both tabs and spaces for indentation. Please choose one and
not
    using both (for cosmetic issue)
Please fix the issues above when importing to Fedora CVS.
Well,
* This package itself is okay
* Usually a new contributor who needs to get sponsored has to "show that you
have an understanding 
  of the process and of the packaging guidelines" as is described on :
  http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored
  One of the way to show this is to submit another review request with enough
quality.
  For your case I already know your other works which I can admit is enough for
sponsoring
  process.

------------------------------------------------------------------------------
              This package (vldocking) is APPROVED by mtasaka
------------------------------------------------------------------------------

Please follow the procedure written on:
http://fedoraproject.org/wiki/PackageMaintainers/Join
from "Get a Fedora Account".
At a point a mail should be sent to sponsor members which notifies
that you need a sponsor. At the stage, please also write on
this bug for confirmation that you requested for sponsorship and
your FAS (Fedora Account System) name. Then I will sponsor you.

If you want to import this package into Fedora 8/9, you also have
to look at
http://fedoraproject.org/wiki/Infrastructure/UpdatesSystem/Bodhi-info-DRAFT
(after once you rebuilt this package on koji Fedora rebuilding system).

If you have questions, please ask me.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.