[Bug 441378] Review Request: smokeping - Latency Logging and Graphing System

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=441378





--- Comment #10 from manuel wolfshant <wolfy at nobugconsulting.ro>  2008-08-30 19:54:29 EDT ---
Package Review
==============

Key:
 - = N/A
 x = Check
 ! = Problem
 ? = Not evaluated

=== REQUIRED ITEMS ===
 [x] Package is named according to the Package Naming Guidelines.
 [x] Spec file name must match the base package %{name}, in the format
%{name}.spec.
 [x] Package meets the Packaging Guidelines.
 [x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
     Tested on: devel/x86_64
 [x] Rpmlint output:
source RPM:E: unknown-key GPG#7666df64
--> ignoreable
binary RPM:
smokeping.noarch: W: non-standard-gid /var/lib/smokeping/images apache
-> needed, the cgi provided by smokeping must be able to create apache readable
images
smokeping.noarch: E: non-standard-dir-perm /var/lib/smokeping/images 02775
--> needed, in order to have the provided CGI create images, but avoidable by
changing the owner/group settings
smokeping.noarch: E: non-readable /etc/smokeping/smokeping_secrets 0640
--> needed, the file contains passwords
 [x] Package is not relocatable.
 [x] Buildroot is correct
(%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n))
 [!] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
--> see issue 1
 [!] License field in the package spec file matches the actual license.
     License type: see issue 1
 [x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
 [x] Spec file is legible and written in American English.
 [x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
     SHA1SUM of package: 055d65c7e3c49cd0d6e8f96242131fe69dc3110e 
/tmp/smokeping-2.4.2.tar.gz
 [x] Package is not known to require ExcludeArch
 [x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
 [-] The spec file handles locales properly.
 [-] ldconfig called in %post and %postun if required.
 [x] Package must own all directories that it creates.
 [x] Package requires other packages for directories it uses.
 [x] Package does not contain duplicates in %files.
 [!] Permissions on files are set properly.
--> see issue 2
 [x] Package has a %clean section, which contains rm -rf %{buildroot}.
 [x] Package consistently uses macros.
 [x] Package contains code, or permissable content.
 [-] Large documentation files are in a -doc subpackage, if required.
 [x] Package uses nothing in %doc for runtime.
 [-] Header files in -devel subpackage, if present.
 [-] Static libraries in -devel subpackage, if present.
 [-] Package requires pkgconfig, if .pc files are present.
 [-] Development .so files in -devel subpackage, if present.
 [-] Fully versioned dependency in subpackages, if present.
 [x] Package does not contain any libtool archives (.la).
 [-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
 [x] Package does not own files or directories owned by other packages.

=== SUGGESTED ITEMS ===
 [x] Latest version is packaged.
 [x] Package does not include license text files separate from upstream.
 [-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
 [x] Reviewer should test that the package builds in mock.
     Tested on: all archs suported by koji scratch build
 [x] Package should compile and build into binary rpms on all supported
architectures.
     Tested on: all archs suported by koji scratch build
 [x] Package functions as described.
 [x] Scriptlets must be sane, if used.
 [-] The placement of pkgconfig(.pc) files is correct.
 [-] File based requires are sane.


=== Issues ===
1. Smokeping itself is GPLv2+ but it relies and includes several modules which
either have no license specified
(/usr/share/smokeping/lib/Smokeping/probes/FPing.pm,
/usr/share/smokeping/lib/Smokeping/probes/EchoPingSmtp.pm and many many others)
or claim to be under the artistic license (/usr/share/smokeping/lib/BER.pm,
/usr/share/smokeping/lib/SNMP_Session.pm,
/usr/share/smokeping/lib/SNMP_util.pm). Unfortunately, despite the fact the
sources claim that the ""Artistic License" is included, the tar file does not
really included it. AFAIK the original Artistic license is not acceptable in
Fedora, so I must ask you to verify that all the included modules do have an
acceptable license.
2. The permissions/ownership as proposed are functional and acceptable, but I
see no reason to use 2775 for the folder where smokeping writes the images. I
think that using apache.root as owner/group and 755 as modes will work just
fine. Please correct me if I am wrong.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.