[Bug 460287] Review Request: htmlparser

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=460287





--- Comment #4 from Ismael Olea <ismael at olea.org>  2008-08-31 06:27:56 EDT ---
(In reply to comment #3)
> Well,
> * I cannot find any notes from the source codes which shows that this software
> can be
>   licensed also under CPL. Are there any explicit declaration?

Yes, it's in their website: http://htmlparser.sourceforge.net/license.html

I've just investigated into the sources of the 2.0 snapshot and it includes
only the CPL. Seems they have changed for the new version.

I'll remove the reference of CPL on 1.6.

> 
> * I forgot to say in my previous comment, howver for "unzip" command would you
> use
>   "unzip -qq foo.zip" to suppress output? (for tar archive, rpmbuild uses "tar
> xf" and
>    does not show the file list in the archive by default).
> 
> * Also I forgot to say in my previous comment, however for cosmetic issue
>   please unify macro usage like %{__unzip} (not %__unzip) if you use
>   %{_javadir} (not %_javadir) and so on.

done

http://olea.org/tmp/htmlparser.spec
http://olea.org/paquetes-rpm/fedora-9/htmlparser-1.6-3olea.src.rpm
http://olea.org/paquetes-rpm/fedora-9/htmlparser-1.6-3olea.noarch.rpm
http://olea.org/paquetes-rpm/fedora-9/htmlparser-javadoc-1.6-3olea.noarch.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.