[Bug 470720] Review Request: gdnet - Demonstration tool for the libdnet interface

bugzilla at redhat.com bugzilla at redhat.com
Sat Dec 6 12:45:23 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=470720





--- Comment #3 from Fabian Affolter <fabian at bernewireless.net>  2008-12-06 07:45:22 EDT ---
Thanks Manuel for your review.

(In reply to comment #2)
> 1. Please get in touch with upstream, clarify the license and ask for inclusion
> of license info in all the source files

fixed.  The developer released a new version with licensing information in the
source.  The license is GPLv2+.

> 2. The desktop file has an ending space on the first line which makes my
> desktop-file-validate choke. Could you please fix it?

fixed.  The developer added the .desktop file to the new version.

> 3. There are some duplicate BuildRequires:gtk2-devel (by libglade2-devel),
> glib2-devel (by gtk2-devel)

fixed

Here are the new files.  But the tools is still not working on my F9 machine
(see Comment #1 for the detail about the error).  I will retest it soon on a
F10 system.  

Spec URL: http://fab.fedorapeople.org/packages/SRPMS/gdnet.spec
SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/gdnet-0.6-1.fc9.src.rpm

Koji scratch builds:
http://koji.fedoraproject.org/koji/taskinfo?taskID=983716

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list