[Bug 461077] Review Request: nxtvepg - A nexTView EPG decoder and browser
bugzilla at redhat.com
bugzilla at redhat.com
Sun Dec 7 17:48:56 UTC 2008
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=461077
Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
--- Comment #30 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2008-12-07 12:48:52 EDT ---
Okay, now for 2.8.1-2:
* Duplicate file entry
-------------------------------------------------------
129 %files
....
142 %{_datadir}/%{name}/
143 %attr(0755, root, root) %{_datadir}/%{name}/tv_grab_ttx.pl
-------------------------------------------------------
- This causes the warning like
-------------------------------------------------------
276 warning: File listed twice: /usr/share/nxtvepg/tv_grab_ttx.pl
-------------------------------------------------------
because the %files entry "%{_datadir}/%{name}" contains
the directory %_datadir/%name itself and all files/directores/etc
under this directory.
For this package it is better that you explicitly modify
the permission of this script at %install like
-------------------------------------------------------
%install
rm -rf %{buildroot}
make %{?_smp_mflags} \
.....
install
.....
.....
chmod 0755 %{buildroot}%{_datadir}/%{name}/*.pl
-------------------------------------------------------
and remove "%attr(........ tv_grah_ttx.pl" line.
Now
- This package itself is okay (but please fix above)
- Now I will sponsor you (if you are still seeking for sponsors)
---------------------------------------------------------------------
This package (nxtvepg) is APPROVED by mtasaka
---------------------------------------------------------------------
Please follow the procedure written on:
http://fedoraproject.org/wiki/PackageMaintainers/Join
from "Get a Fedora Account".
After you request for sponsorship a mail will be sent to sponsor
members automatically (which is invisible for you) which notifies
that you need a sponsor. After that, please also write on
this bug for confirmation that you requested for sponsorship and
your FAS (Fedora Account System) name. Then I will sponsor you.
If you want to import this package into Fedora 10/9, you also have
to look at
http://fedoraproject.org/wiki/Infrastructure/UpdatesSystem/Bodhi-info-DRAFT
(after once you rebuilt this package on koji Fedora rebuilding system).
If you have questions, please ask me.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list