[Bug 476160] Review Request: perl-Directory-Scratch - Self-cleaning scratch space for tests
bugzilla at redhat.com
bugzilla at redhat.com
Fri Dec 12 06:23:10 UTC 2008
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=476160
Parag AN(पराग) <panemade at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |panemade at gmail.com
AssignedTo|nobody at fedoraproject.org |panemade at gmail.com
Flag| |fedora-review+
--- Comment #2 from Parag AN(पराग) <panemade at gmail.com> 2008-12-12 01:23:09 EDT ---
Review:
+ package builds in mock (rawhide i386).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=994338
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
3e759c3a5ff8c678725aad99e80a5c14 Directory-Scratch-0.14.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=37, Tests=268, 6 wallclock secs ( 0.20 usr 0.07 sys + 4.96 cusr 0.49
csys = 5.72 CPU)
+ Package perl-Directory-Scratch-0.14-2.fc11 =>
Provides: perl(Directory::Scratch) = 0.14
Requires: perl(Carp) perl(File::Copy) perl(File::Slurp) perl(File::Spec)
perl(File::Temp) perl(File::stat) perl(Path::Class) perl(Scalar::Util)
perl(overload) perl(strict) perl(warnings)
APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list