[Bug 226420] Merge Review: slang

bugzilla at redhat.com bugzilla at redhat.com
Fri Dec 12 13:31:10 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226420





--- Comment #5 from Jon Ciesla <limb at jcomserv.net>  2008-12-12 08:31:09 EDT ---
(In reply to comment #4)
> The changelog is a mix of UTF8 and ISO-8859-1.

Right.  Should be UTF-8.

> Source seems to be a valid rpm tag, or is there a guideline requiring use of
> Source0?

I got confused, I was thinking pf Patch vs. Patch0.  Still a good practice, but
not a blocker.

> The patches were not send to upstream, they just fix some file permissions,
> rpath and disable using a private glibc symbol to follow our guidelines.

https://fedoraproject.org/wiki/Packaging/Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment
So fix the changelog ang comment on the patches in the spec and we're good.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.




More information about the package-review mailing list