[Bug 469585] Review Request: moon-buggy - Drive and jump with some car across the moon
bugzilla at redhat.com
bugzilla at redhat.com
Fri Dec 12 18:35:14 UTC 2008
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=469585
Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mtasaka at ioa.s.u-tokyo.ac.jp
--- Comment #12 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2008-12-12 13:35:12 EDT ---
Some notes:
* License
- is actually "GPL+". Only putting GPLv2 license text
in the source tarball and not specifying any version
on any other source codes renders the version to be
not only version 2 but also at any version:
http://fedoraproject.org/wiki/Licensing/FAQ
* autotool autocall
- build.log shows:
-------------------------------------------------------------------------
195 configure: creating ./config.status
196 config.status: creating Makefile
197 config.status: creating config.h
198 config.status: executing depfiles commands
199 + make -j8
200 cd . && /bin/sh /builddir/build/BUILD/moon-buggy-1.0.51/missing --run
autoheader
201 rm -f stamp-h1
202 touch config.h.in
203 cd . && /bin/sh ./config.status config.h
204 config.status: creating config.h
205 make all-am
-------------------------------------------------------------------------
Here autotools (like autoheader) are automatically called and
this is not desired (because this changes files unexpectedly).
Usually this can be avioded by "touch"ing some autotool related
files correctly.
! Timestamp
-------------------------------------------------------------------------
make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"
-------------------------------------------------------------------------
- is recommended to keep timestamps on installed files as much
as possible.
This method usually works for Makefiles generated by recent
autotools.
! Note
- Usually Game SIGs suggests that games data files must be
packaged seperately, however for this game as sound tarball
is not large, I don't feel the necessity to create another
srpm for sound tarball.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list