[Bug 226550] Merge Review: xcdroast

bugzilla at redhat.com bugzilla at redhat.com
Mon Dec 15 10:11:12 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226550


Fabian Affolter <fabian at bernewireless.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fabian at bernewireless.net




--- Comment #1 from Fabian Affolter <fabian at bernewireless.net>  2008-12-15 05:11:11 EDT ---
Just some comments...

- X-CD-Roast 0.98alpha16 released
  http://www.xcdroast.org/#download
- Summary ends with a dot
- Use %defattr(-,root,root,-) instead of %defattr(-,root,root)
- Use parallel make (make %{?_smp_mflags})
- Package doesn't consistently use macros
- Please add a note because 'PREFIX=/usr' is used
  https://fedoraproject.org/wiki/Packaging/Guidelines#Relocatable_packages

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.




More information about the package-review mailing list