[Bug 476404] Review Request: bullet - 3D Collision Detection and Rigid Body Dynamics Library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=476404


Conrad Meyer <konrad at tylerc.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |konrad at tylerc.org
            Summary|Review Request: 3D          |Review Request: bullet - 3D
                   |Collision Detection and     |Collision Detection and
                   |Rigid Body Dynamics Library |Rigid Body Dynamics Library




--- Comment #1 from Conrad Meyer <konrad at tylerc.org>  2008-12-16 04:48:52 EDT ---
Some thoughts:
- Summary would be nice if it could be a bit shorter (I'm not sure if there's
policy about this, but it makes it nicer on e.g. PackageKit).
- Group: I would say Development/Libraries (I think System
Environment/Libraries is reserved for pretty core parts of Fedora)
- License: Zlib is acceptable in Fedora; I think we like it lowercase, though
(http://fedoraproject.org/wiki/Licensing).
- %description: policy is to keep it below 80 characters wide, IIRC.
- In general I think it improves legibility to align the sections with spaces
but it's certainly not a requirement.

- If it builds on koji (could you add a link to that build in a comment,
please?) then you probably have the BuildRequires. 'make' is unnecessary as it
is part of the default build root.
- Same notes as above about Group for -devel subpackage.
- Generally for Summary/%description for -devel subpackages we put something
like "Development files for %{name}" and "Development headers and libraries for
%{name}."

- %prep: move cmake to %build
- %build: As we talked about on IRC, use %cmake.
- %install: NEED 'rm -rf $RPM_BUILD_ROOT' as the first thing.
- I believe you need ldconfig in %post as well as %postun. rpmlint should warn
about not having one of those.

- Same doc files between main package and -devel subpackage is redundant.
- /usr/lib/*.so should be in -devel, not main package.
- Replace literal "/usr/lib" with "%{_libdir}".
- /usr/include/ with %{_includedir}
- %changelog needs a version per entry.

ex:
%changelog
* Mon Dec 15 2008 Bruno Mahe <bruno[AT]gnoll.org> - 2.73-2
- Some changes.

* Sat Dec 13 2008 Bruno Mahe <bruno[AT]gnoll.org> - 2.73-1
- Initial build.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.