[Bug 467407] Review Request: mingw32-sqlite - MinGW Windows port of sqlite embeddable SQL database engine

bugzilla at redhat.com bugzilla at redhat.com
Tue Dec 16 16:03:55 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=467407


Richard W.M. Jones <rjones at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|needinfo?(rjones at redhat.com |
                   |)                           |




--- Comment #3 from Richard W.M. Jones <rjones at redhat.com>  2008-12-16 11:03:54 EDT ---
rpmlint isn't hugely useful for mingw packages at the moment.
Upstream rpmlint refused to make changes to accomodate the
packaging guidelines, but hopefully we can add some custom
rules at some point in the future.

The updated package here now has the following rpmlint
warnings:

mingw32-sqlite.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/lib/pkgconfig/sqlite3.pc
mingw32-sqlite.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/sqlite3.h
mingw32-sqlite.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/sqlite3ext.h
mingw32-sqlite.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/lib/libsqlite3.dll.a

These are fine.  All mingw packages are development
packages, so there is no -devel subpackage.

mingw32-sqlite.noarch: E: script-without-shebang
/usr/i686-pc-mingw32/sys-root/mingw/lib/libsqlite3.la

Note that we currently include *.la files in mingw
packages, because libtool (probably) requires them
for linking.

mingw32-sqlite.noarch: E: arch-independent-package-contains-binary-or-object
/usr/i686-pc-mingw32/sys-root/mingw/lib/libsqlite3.dll.a

This is OK because the file in question contains Windows
binary stubs - ie. arch-independent from the p.o.v. of
Fedora.

mingw32-sqlite.noarch: W: non-standard-dir-in-usr i686-pc-mingw32

And again, this is OK, mandated by GCC and the packaging
guidelines.

I've fixed the spurious executable permission, and added
'Requires: pkgconfig' which is needed.

Spec URL: http://www.annexia.org/tmp/mingw32-sqlite.spec
SRPM URL: http://www.annexia.org/tmp/mingw32-sqlite-3.6.6.2-1.fc10.src.rpm

* Tue Dec 16 2008 Richard Jones <rjones at redhat.com> - 3.6.6.2-1
- New upstream release (to match Fedora native), 3.6.6.2.
- Replace patches with ones from native.
- Rebase -no-undefined patch.
- Remove spurious +x permissions on libsqlite3.dll.a.
- Requires pkgconfig.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list