[Bug 465943] Review Request: NetworkManager-openconnect - NetworkManager VPN integration for openconnect

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=465943





--- Comment #11 from Peter Robinson <pbrobinson at gmail.com>  2008-12-16 19:56:55 EDT ---
A few fixes required. Also as a side note it doesn't look like libgnome is used
in the source files but its included in the configure checks but I'm not sure.

+ rpmlint output

$ rpmlint NetworkManager-openconnect.spec 
NetworkManager-openconnect.spec: W: mixed-use-of-spaces-and-tabs (spaces: line
1, tab: line 70)
0 packages and 1 specfiles checked; 0 errors, 1 warnings.

+ package name satisfies the packaging naming guidelines
+ specfile name matches the package base name
+ package should satisfy packaging guidelines
+ license meets guidelines and is acceptable to Fedora
- license matches the actual package license

There's no COPYING file included in the source. Some of the source files
include the license but some don't include any at all.

+ %doc includes license file
+ spec file written in American English
+ spec file is legible
- upstream sources match sources in the srpm
  399dc23f2df67d994770dfdfdaec0ecb 
NetworkManager-openconnect-0.7.0.svn3.tar.gz

  Package needs to adhere to source requirements, if its using VCS snapshots it
needs to be specified as per the Packaging docs.
  https://fedoraproject.org/wiki/Packaging/SourceURL

+ package successfully builds on at least one architecture
  built fine in koji
- BuildRequires list all build dependencies

Not sure why libpng is required. It builds fine without it and doesn't seem to
check for it in the configure script.

+ %find_lang instead of %{_datadir}/locale/*
  Documented that there's no translations yet but its handled
+ binary RPM with shared library files must call ldconfig in %post and %postun
+ does not use Prefix: /usr
- package owns all directories it creates

/usr/share/gnome-vpn-properties/openconnect/ is not owned by the package 
/usr/share/gnome-vpn-properties/ isn't either and should probably be owned by
NetworkManager itself as more than one NM vpn package installs things there.

n/a no duplicate files in %files
+ %defattr line
+ %clean contains rm -rf $RPM_BUILD_ROOT
+ consistent use of macros
+ package must contain code or permissible content
n/a large documentation files should go in -doc subpackage
+ files marked %doc should not affect package
n/a header files should be in -devel
n/a static libraries should be in -static
n/a packages containing pkgconfig (.pc) files need 'Requires: pkgconfig'
n/a libfoo.so must go in -devel
n/a devel must require the fully versioned base
+ packages should not contain libtool .la files
n/a packages containing GUI apps must include %{name}.desktop file
+ packages must not own files or directories owned by other packages
- %install must start with rm -rf $RPM_BUILD_ROOT etc.
  needs to remove old buildroots
+ filenames must be valid UTF-8

Optional:

- if there is no license file, packager should query upstream
  mentioned above
n/a translations of description and summary for non-English languages, if
available
+ reviewer should build the package in mock
+ the package should build into binary RPMs on all supported architectures
+ review should test the package functions as described (basic testing but
don't have a Cisco Anyconnect VPN currently available)
+ scriptlets should be sane
n/a pkgconfig files should go in -devel
+ shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or
/usr/sbin

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.