[Bug 478432] Review Request: dwscan - Displays access point information

bugzilla at redhat.com bugzilla at redhat.com
Tue Dec 30 09:23:41 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478432


Ralf Corsepius <rc040203 at freenet.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rc040203 at freenet.de




--- Comment #1 from Ralf Corsepius <rc040203 at freenet.de>  2008-12-30 04:23:40 EDT ---
Some remarks:

- Your patch is superfluous.
  Overriding at make-time:
  make install bindir=%{_bindir}
  has the same effect without hacking the code.

- The Makefile doesn't honor INSTALL 
  => make INSTALL="install -p"
  is non-functional

Furthermore:
- I am having strong doubts if installing this tool to %{_bindir} is a good
idea.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list