[Bug 475058] Review Request: netbeans-platform - NetBeans 6.5 Platform 9

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=475058





--- Comment #5 from Adel Gadllah <adel.gadllah at gmail.com>  2008-12-31 08:00:23 EDT ---
(In reply to comment #4)
> (In reply to comment #3)
> Adel, thanks for review. The next release is prepared.
> 
> Spec URL: http://victorv.fedorapeople.org/files/netbeans-platform.spec
> SRPM URL:
> http://victorv.fedorapeople.org/files/netbeans-platform-6.5-3.fc11.src.rpm
> Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1026772
> 
> Changes and comments:
> ---------------------
> 
> > [1] specfile is properly named, is cleanly written and uses macros consistently.
> > Do we really need the "Distrubution" tag? AFAIK nothing in Fedora makes use of
> > it. Package groups are handled via comps.
> I absolutely agree. It is my fault.
> - The "Distrubution" tag is deleted

OK

> > Changelog:
> > Please remove the "6.1" references because they are not really related to this
> > package.(changelog entries from the former "platform8" package)
> - The "6.1" references are removed from the changelog

OK

> > [3] final provides and requires are sane.
> OK. No any changes.

> > [3] scriptlets are sane
> > rpm -qp netbeans-platform-6.5-2.fc11.noarch.rpm --provides
> > libnb-platform9 = 6.5
> > netbeans-platform = 6.5-2.fc11
> > rpm -qp netbeans-platform-harness-6.5-2.fc11.noarch.rpm --provides
> > libnb-platform9-devel = 6.5
> > netbeans-platform-harness = 6.5-2.fc11
> >
> > Any reason why they are called "libnb-platform9" and "libnb-platform9-devel" ?
> > Those should be renamed to libnb-plaform/-devel (other packages can use the
> > version to require it).
> An idea was to support a relation between packages across various Linux
> distributions. I agree it has not much sense for the Fedora packages.
> So, to make the package spec more clear for Fedora I've removed it at all.
> - Specifications of providing non-Fedora packages are removed

OK

> > [2] rpmlint is silent.
> > Its not see comments above. The only thing that can/should be fixed are the
> > "W: dangerous-command-in-%preun rm" warnings, see [4]
> > ...
> > [4]
> > Whats the purpose of the noautoupdate scriptlets?
> > Wouldn't it be better to just package those files (generate them in %install
> > section and add entries in %files). This way rpm will handle the
> > deletion/creation of this files and there would be no need for the scriptlets.
> By default all the NetBeans packages rely on the RPM facilities to complete
> updating. Nevertheless, the NetBeans has own update subsystem called as "update
> center". A .noautoupdate file disables auto update of a NetBeans cluster via
> update center.
> An idea to create/delete the .noautoupdate files in %post/%preun scriptlets is
> giving a chance for a user with the root rights to choose an alternative way
> for updating of the NetBeans clusters. It may be reached if the user will use
> the RPM option --noscripts for installation of a package (i.e. cluster). Note,
> this feature won't be used by default.
> If you agree to save this feature of the netbeans-platform package then I won't
> change it.

Well I am not sure why anyone would want to mess with an rpm installed package
this way. If someone does not want to use rpms to update, he should just
install the upstream tarball. Also updating this way breaks tracking via rpm
and rpm -V will no longer be able to verify the installation. Other packages
(ex: firefox) disable this option for the same reason.

The update center should only update plugins a user has installed in his home
directory, so I think we should just remove the scriptlets and package those
files as part of the rpm.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.