[Bug 431277] Review Request: ocfs2-tools - programs for managing Ocfs2 file systems

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocfs2-tools - programs for managing Ocfs2 file systems


https://bugzilla.redhat.com/show_bug.cgi?id=431277





------- Additional Comments From mark at fasheh.com  2008-02-04 18:07 EST -------
(In reply to comment #7)
> I can't sponsor you but a quick review nevertheless:

Thank you for the review - it has been very helpful and I've implemented the
vast majority of what you've pointed out:

I dropped the Exclusiveos tag and added a disttag. Also, I'm now using
%{_datadir}, %{_initrddir} and %{python_sitearch} whenever possible.

BuildRoot is now
"%{_tmppath}/%{name}-%{PACKAGE_VERSION}-%{PACKAGE_RELEASE}-root" which is one of
the approved alternates which you mentioned.

The requires line for ocfs2-tools-devel has been fixed - thanks for noticing that.


A new spec file / srpm has been uploaded and I'll attach the spec to this bug.
Since so much has changed, I bumped the release number:


Spec URL: http://oss.oracle.com/~mfasheh/fedora/ocfs2-tools.spec
SRPM URL:
http://oss.oracle.com/~mfasheh/fedora/ocfs2-tools-1.3.9-5.20080131git.fc8.src.rpm


The rest of my comments follow:

> You must drop all BuildRequires that are part of the default build root such as
> bash.

I think we're already clean with respect to buildrequires. There's certainly no
bash line in there - maybe you were looking at the requires instead?


> Why is there a Provides: ocfs2-tools-static = %{version}-%{release}? Can't you
> dynamically link libraries? If not, you should provide a justification for
> statically linking any libraries. 
> 
> Refer 
> 
>
http://fedoraproject.org/wiki/Packaging/Guidelines#head-2302ec1e1f44202c9cc4bcce24cb711266557ad7

The page you reference states:

"When a package only provides static libraries you can place all the files in
the *-devel subpackage. When doing this you also have to have a virtual Provide
for the static package:"

Ocfs2-tools is one such package, and I've followed the guidelines set out there.


> Use make %{?_smp_mflags} if possible. 

Unfortunately, ocfs2-tools doesn't support parallel builds at this time.

Thanks again!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.