[Bug 431277] Review Request: ocfs2-tools - programs for managing Ocfs2 file systems

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocfs2-tools - programs for managing Ocfs2 file systems


https://bugzilla.redhat.com/show_bug.cgi?id=431277





------- Additional Comments From sundaram at redhat.com  2008-02-04 19:42 EST -------
I guess I misread the BuildRequires. 

Change the buildroot to

%{_tmppath}/%{name}-%{version}-%{release}-root

The guidelines recommend against mixing two styles 

http://fedoraproject.org/wiki/Packaging/Guidelines#head-f3d77b27a5d29dfc1f5600ef3fc836f2e317badf

The part of the guidelines, I wanted you to refer to regarding static libs was, 

"In general, packagers are strongly encouraged not to ship static libs unless a
compelling reason exists."

If you do have compelling reasons, it would be good to specify that in the
review. Other than those minor nit-picks, the latest spec looks ok to me. I did
a scratch build of the latest ocfs2 srpm and it builds and installs correctly.

http://koji.fedoraproject.org/koji/taskinfo?taskID=395837

A sponsor has to do a official review and approve your spec before you get
commit access.

http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.