[Bug 225615] Merge Review: binutils

bugzilla at redhat.com bugzilla at redhat.com
Wed Feb 6 22:53:59 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: binutils


https://bugzilla.redhat.com/show_bug.cgi?id=225615


pertusus at free.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pertusus at free.fr




------- Additional Comments From pertusus at free.fr  2008-02-06 17:53 EST -------
I think it would be better to change the perl substitution
to a sed substitution.

the gzipping of info files will be done automatically,
and install-info knows how to install/remove compressed info files.

I suggest using
%defattr(-,root,root,-) instead of %defattr(-,root,root)

Why not use %configure and why use %makeinstall? Looks like
DESTDIR is rightly used.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the package-review mailing list