[Bug 426492] Review Request: jabbin - Instant messaging and VoIP Jabber client
bugzilla at redhat.com
bugzilla at redhat.com
Sun Feb 10 14:04:09 UTC 2008
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: jabbin - Instant messaging and VoIP Jabber client
https://bugzilla.redhat.com/show_bug.cgi?id=426492
------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp 2008-02-10 09:04 EST -------
Created an attachment (id=294496)
--> (https://bugzilla.redhat.com/attachment.cgi?id=294496&action=view)
Patch to honor Fedora cflags correctly
Thank you to Hans for fixing gcc43 related issues!
For 2.0-0.4:
* License
-----------------------------------------------------
src/tools/openpgp/gpgproc/ Dual of QPL and GPLv2 (strict)
-----------------------------------------------------
- License tag must be GPLv2 (strict).
* Compiler flags
- Fedora specific compilation flags are not honored correctly.
http://koji.fedoraproject.org/koji/taskinfo?taskID=411301
The proposal patch attached fixes this issue.
http://koji.fedoraproject.org/koji/taskinfo?taskID=411576
* Timestamps
- When using "cp" or "install" commands, please use "-p" option
to keep timestamps on installed files.
------------------------------------------------------
install -m 644 certs/readme certs/rootcert.xml
$RPM_BUILD_ROOT%{_datadir}/%{name}/certs
------------------------------------------------------
Please fix the 3 issues above before committing into CVS.
Other things are okay.
------------------------------------------------------
This package (jabbin) is APPROVED by me
------------------------------------------------------
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the package-review
mailing list