[Bug 432139] Review Request: kiconedit - An icon editor for KDE4

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kiconedit - An icon editor for KDE4


https://bugzilla.redhat.com/show_bug.cgi?id=432139


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From panemade at gmail.com  2008-02-11 20:13 EST -------
Review:
+ package builds in mock (rawhide i386).
koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=405369
+ rpmlint is silent for SRPM But NOT for RPM.
kiconedit.i386: W: dangling-symlink /usr/share/doc/HTML/en/kiconedit/common
/usr/share/doc/HTML/en/common
kiconedit.i386: W: symlink-should-be-relative
/usr/share/doc/HTML/en/kiconedit/common /usr/share/doc/HTML/en/common
==> Ok to accept here
+ source files match upstream.
77f69d70f105f83713e427ae0c8f1e5b  kcoloredit-4.0.1.tar.bz2
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ Compiler flags are honored correctly.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ xdg-utils scriptlets are used.
+ Desktop file installed correctly.
+ GUI app.

APPROVED.



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.