[Bug 433082] Review Request: libax24 - AX.25 library for hamradio applications

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libax24 - AX.25 library for hamradio applications


https://bugzilla.redhat.com/show_bug.cgi?id=433082


kanarip at kanarip.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |kanarip at kanarip.com
             Status|NEW                         |NEEDINFO
               Flag|                            |fedora-review?,
                   |                            |needinfo?(bob at fedoraunity.or
                   |                            |g)




------- Additional Comments From kanarip at kanarip.com  2008-02-15 20:45 EST -------
RPM Lint: OK
Package name: OK
Spec file: OK
License: OK
Actual License: LPGLv2+ (from source files: `grep -rin -A 2 lesser *` inside the
source tree shows, COPYING has LGPLv2.1)
%doc License: OK
Spec file language: OK
Spec file readable: OK
Upstream source vs. used tarball: OK (md5sum match)
Compile and Build:
 - F7 OK
 - F8 OK
 - rawhide OK
 - EL5 OK

Applicable Package Guidelines:
 - -debuginfo package: OK (~49K)
 - -devel package: FAILED (see below)

Locales: N/A
Shared libs: OK
Relocatable: N/A
Directory and file ownership: OK
No duplicate files in %files: OK
File Permissions: OK
Macro usage: OK
Code vs. Content: OK
(Large) Documentation: N/A
%doc affecting runtime: OK
Header files in -devel package: FAILED (see below)
Static Libraries in -static package: N/A
pkgconfig Requires: N/A
Library files: OK
Devel requires base package: OK
.la libtool archives: N/A
Duplicate ownership of files/directories: OK
Remove BuildRoot: OK
UTF-8 filenames: OK

==

Below shows that the base package lacks a couple of files (man pages for
example), whereas the -devel package picks them up.

[jmeeuwen at unity05 fedora-ham]$ rpm -qlp
/var/lib/mock/fedora-8-i386/result/libax25-devel-0.0.11-2.fc8.i386.rpm 
/usr/include/netax25
/usr/include/netax25/ax25io.h
/usr/include/netax25/axconfig.h
/usr/include/netax25/axlib.h
/usr/include/netax25/daemon.h
/usr/include/netax25/kernel_ax25.h
/usr/include/netax25/kernel_netrom.h
/usr/include/netax25/kernel_rose.h
/usr/include/netax25/mheard.h
/usr/include/netax25/nrconfig.h
/usr/include/netax25/procutils.h
/usr/include/netax25/rsconfig.h
/usr/include/netax25/ttyutils.h
/usr/lib/libax25.so
/usr/lib/libax25io.so
/usr/share/doc/libax25-devel-0.0.11
/usr/share/doc/libax25-devel-0.0.11/AUTHORS
/usr/share/doc/libax25-devel-0.0.11/COPYING
/usr/share/doc/libax25-devel-0.0.11/ChangeLog
/usr/share/doc/libax25-devel-0.0.11/README
/usr/share/man/man3/ax25.3.gz
/usr/share/man/man3/rose.3.gz
/usr/share/man/man5/axports.5.gz
/usr/share/man/man5/nrports.5.gz
/usr/share/man/man5/rsports.5.gz
[jmeeuwen at unity05 fedora-ham]$ rpm -qlp
/var/lib/mock/fedora-8-i386/result/libax25-0.0.11-2.fc8.i386.rpm 
/usr/lib/libax25.so.0
/usr/lib/libax25.so.0.0.0
/usr/lib/libax25io.so.0
/usr/lib/libax25io.so.0.0.0
/usr/share/doc/libax25-0.0.11
/usr/share/doc/libax25-0.0.11/COPYING
/usr/share/doc/libax25-0.0.11/README

==

Replace the %files sections in the .spec with: (and things should be OK)

%files
%defattr(-,root,root,-)
%doc AUTHORS ChangeLog COPYING README
%{_libdir}/*.so.*
%{_mandir}/man?/*

%files devel
%defattr(-,root,root,-)
%{_includedir}/*
%{_libdir}/*.so


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.