[Bug 426868] Review Request: glpi-pdf - GLPI Plugin to print PDF of computers

bugzilla at redhat.com bugzilla at redhat.com
Sat Feb 16 07:03:38 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: glpi-pdf -  GLPI Plugin to print PDF of computers


https://bugzilla.redhat.com/show_bug.cgi?id=426868


johan at x-tnd.be changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |johan at x-tnd.be
               Flag|                            |fedora-review+




------- Additional Comments From johan at x-tnd.be  2008-02-16 02:03 EST -------
Review:
+ package builds in mock.
+ rpmlint is silent for SRPM and RPMs.
+ source file are ok.
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ BuildRequires are proper.
+ package installed properly.
+ Macro use appears rather consistent.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the package-review mailing list