[Bug 433253] Review Request: dotconf - Required for speech dispatcher on OLPC XO
bugzilla at redhat.com
bugzilla at redhat.com
Wed Feb 20 06:56:00 UTC 2008
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: dotconf - Required for speech dispatcher on OLPC XO
https://bugzilla.redhat.com/show_bug.cgi?id=433253
------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp 2008-02-20 01:55 EST -------
Well, would you again try to follow lib skeleton spec file again?
- The ELF shared library (usually libXXXX.so.X.X) and its ldconfig
symlink (usually libXXXXX.so.X) must not be in -devel subpackage.
Only the symlink used for linkage (libXXXX.so) should be in
-devel subpackage.
- pkgconfig .pc file should not be deleted and should be included
in -devel subpackage. Then -devel subpackage should
have "Requires: pkgconfig" (please check
http://fedoraproject.org/wiki/Packaging/ReviewGuidelines)
Also:
- Please make Summary a bit more verbose. the summary "dot.conf"
is not useful.
- I recommend to use %{name} and %{version} in Source0 URL.
In this way you don't have to modify Source0 when the version
of the tarball is upgraded.
- I recommend to use
-------------------------------------------------------------------------
make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"
-------------------------------------------------------------------------
to keep timestamps on installed files. This method usually
works for recent autotool-based Makefiles.
- The file "INSTALL" is usually for people who want to compile
and install the package by themselves and is not needed for people
who use rpm.
- For directory ownership issue of %{_datadir}/aclocal and for
usability, I recommend to add "Requires: automake" to -devel
subpackage (not BuildRequires).
- For %{_bindir}/dotconf-config (in the source tarball it was
dotconf-config.in), @libdir@ is expanded as /usr/lib on 32bits
machine but /usr/lib64 on 64bits machine on Fedora.
This means that /usr/bin/dotconf-config differs between
on 32 bits machine and on 64 bits machine. Currently Fedora
does not allow this type of multilib conflicts for -devel
subpackage.
You can use "rpmlint" (in rpmlint rpm) to detect some generic
issues on your rpms. For example of a library rpm,
you can check:
http://cvs.fedoraproject.org/viewcvs/*checkout*/devel/oniguruma/oniguruma.spec
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the package-review
mailing list