[Bug 241596] Review Request: maildrop - Mail delivery agent with filtering abilities

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: maildrop - Mail delivery agent with filtering abilities


https://bugzilla.redhat.com/show_bug.cgi?id=241596





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2008-03-06 10:39 EST -------
For 2.0.4-5:

* License tag
  - License tag "GPL" is no longer valid for Fedora.
    http://fedoraproject.org/wiki/Packaging/LicensingGuidelines
    http://fedoraproject.org/wiki/Licensing

* Static archive only -devel subpackage packaging
  - For static archive only -devel subpackage, please follow
    "Packaging Static Libraries" subsection of
    http://fedoraproject.org/wiki/Packaging/Guidelines

* /sbin/ldconfig
  - Why is calling of /sbin/ldconfig on %post/%postun needed?

* Header file include:
  - For example, /usr/include/rfc2045.h contains:
---------------------------------------------------------------
    12  #include        "../rfc2045/rfc2045_config.h" /* VPATH build */
---------------------------------------------------------------
    but rfc2045_config.h does not exist. 

! fedora specific compilation flags
  - Well, now from build.log, I cannot check if Fedora specific
    compilation flags are correctly honored (from the output like
    below:)
---------------------------------------------------------------
  1932  make[2]: Entering directory `/builddir/build/BUILD/maildrop-2.0.4/numlib'
  1933  Compiling atotimet.c
  1934  Compiling atouidt.c
  1935  Compiling changeuidgid.c
  1936  Compiling strdevt.c
  1937  Compiling strgidt.c
---------------------------------------------------------------
    Please make the build.log more verbose so that we can check
    how compiler flags are used from build.log.

! /usr/bin/sendmail
  - Well, perhaps no one except for me may complain about this,
    however currencly sendmail license is in question
    (ref: bug 409361). Is it possible to make this package avoid
    sendmail?


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.