[Bug 436481] Review Request: <perl-Net-Amazon-S3> - <Use the Amazon Simple Storage Service (S3)>

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: <perl-Net-Amazon-S3> - <Use the Amazon Simple Storage Service (S3)>


https://bugzilla.redhat.com/show_bug.cgi?id=436481


nsantos at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |nsantos at redhat.com
             Status|NEW                         |ASSIGNED




------- Additional Comments From nsantos at redhat.com  2008-03-07 15:03 EST -------
Reviewed according to guidelines at
http://fedoraproject.org/wiki/Packaging/ReviewGuidelines

Builds under mock (on devel):

$ mock perl-Net-Amazon-S3-0.43-1.fc8.src.rpm 
INFO: mock.py version 0.9.7 starting...
State Changed: init plugins
State Changed: start
INFO: Start(perl-Net-Amazon-S3-0.43-1.fc8.src.rpm)  Config(fedora-development-i386)
State Changed: lock buildroot
State Changed: clean
State Changed: init
State Changed: lock buildroot
INFO: enabled root cache
INFO: enabled yum cache
State Changed: cleaning yum metadata
INFO: enabled ccache
State Changed: running yum
State Changed: creating cache
State Changed: setup
State Changed: build
INFO: Done(perl-Net-Amazon-S3-0.43-1.fc8.src.rpm) Config(default) 1 minutes 30
seconds
INFO: Results and/or logs in: /var/lib/mock//fedora-development-i386/result

$ cd /var/lib/mock//fedora-development-i386/result
$ ls -alF
total 92
drwxrwsr-x 2 nsantos mock  4096 2008-03-07 15:00 ./
drwxrwsr-x 4 root    mock  4096 2008-03-07 14:59 ../
-rw-rw-r-- 1 nsantos mock  6156 2008-03-07 15:00 build.log
-rw-r--r-- 1 nsantos mock 32447 2008-03-07 15:00
perl-Net-Amazon-S3-0.43-1.fc9.noarch.rpm
-rw-r--r-- 1 nsantos mock 24397 2008-03-07 15:00
perl-Net-Amazon-S3-0.43-1.fc9.src.rpm
-rw-rw-r-- 1 nsantos mock 12869 2008-03-07 15:00 root.log
-rw-rw-r-- 1 nsantos mock   266 2008-03-07 15:00 state.log

$ rpmlint *.rpm
(no output)


As for your other package, the only two things missing are:
- Every %files section must include a %defattr(...) line.
- missing packager name on the changelog


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.