[Bug 436905] Review Request: perl-JSON-Any - A meta-module to make working with JSON easier

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-JSON-Any - A meta-module to make working with JSON easier
Alias: perl-JSON-Any

https://bugzilla.redhat.com/show_bug.cgi?id=436905


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From panemade at gmail.com  2008-03-11 01:52 EST -------
Thanks for putting comments in advance in SPEC for additional JSON packages.

Review:
+ package builds in mock.
Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=509740
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
37325d39aa62b291d05b9e90d2df12a0  JSON-Any-1.16.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0,
'inc', 'blib/lib', 'blib/arch')" t/00-load.t t/01-JSON.t t/02-JSON-XS.t
t/03-JSON-DWIW.t t/04-ENV.t t/05-JSON-Syck.t t/10_unicode.t
t/00-load.........# Testing JSON::Any 1.16, Perl 5.010000, /usr/bin/perl
ok
t/01-JSON.........# Testing JSON.pm backend
ok
t/02-JSON-XS......# Testing JSON::XS backend
ok
t/03-JSON-DWIW....skipped
        all skipped: JSON::DWIW not installed: Couldn't find a JSON Package. at
(eval 3) line 1
t/04-ENV..........ok
t/05-JSON-Syck....ok
t/10_unicode......# handler is JSON::XS
# handler is JSON::Backend::XS::Supportable
# DWIW: Couldn't find a JSON Package. at t/10_unicode.t line 18
# Syck: JSON::Syck does not support utf8 at t/10_unicode.t line 19
# PC: Couldn't find a JSON Package. at t/10_unicode.t line 18
ok
All tests successful, 1 test skipped.
Files=7, Tests=80,  1 wallclock secs ( 0.39 cusr +  0.04 csys =  0.43 CPU)

APPROVED.



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.